Fix outputting dynamic bundles, fixes #472 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When #443 was merged, it moved the list of dynamic bundle names to a metadata property on the `scripts:bundle` node. However, the `bankai build` command was never updated to match.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix
When #443 was merged, it moved the list of dynamic bundle names to a
metadata property on the
scripts:bundlenode. However, thebankai buildcommand was never updated to match.Checklist
We don't have tests yet for the build and it's tricky. Guess we'd just
need to kick off a child process
Context
#472
Semver Changes
Patch