ci: fix CI for external contributors #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of our CI jobs recently started relying on a repo secret to log into Docker Hub. This is not strictly necessary, but was done to make the job less flaky, since we were hitting rate limits on Docker's API server. However, this actually broke the workflow for external contributors, since forks do not have access to repo secrets. It would be a significant security challenge to make this work for external contributors, so I'm leaving this as future work for now. Instead, let's fix the more immediate problem by simply only attempting a login when the PR comes from within the Cilium org. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
added
area/ci
mtardy
approved these changes
Oct 24, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our CI jobs recently started relying on a repo secret to log into Docker Hub. This is not strictly necessary, but was done to make the job less flaky, since we were hitting rate limits on Docker's API server. However, this actually broke the workflow for external contributors, since forks do not have access to repo secrets.
It would be a significant security challenge to make this work for external contributors, so I'm leaving this as future work for now. Instead, let's fix the more immediate problem by simply only attempting a login when the PR comes from within the Cilium org.