Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: fix CI for external contributors #1649

Merged
merged 1 commit into from
Oct 24, 2023
Merged

ci: fix CI for external contributors #1649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/packages-e2e-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ jobs:
id: tag
run: echo "tag=$(make version)" >> $GITHUB_OUTPUT

# Logging into Docker Hub makes the job less flaky, but it relies on repo secrets so
# does not work for external contributors. Let's compromise and do this for internal
# PRs at least (for now). We can always improve the situation later.
- name: Login to Docker Hub
if: ${{ github.event.pull_request.head.repo.full_name == 'cilium/tetragon' }}
uses: docker/#-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0
with:
username: ${{ secrets.DOCKER_HUB_USERNAME_CI }}
Expand Down