Worker: do not report the task as failed if it's context was canceled #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately,
golang.org/x/crypto/sshdoes not supportcontext.Contextand when we close*ssh.Clientin the monitor's snippet due to context cancellation, we can get pretty much all sorts of random errors, depending on which stage the SSH connection was in, but we won't get thecontext.Canceledwhich we already try to filter out.I think the simplest way to work around this is to additionally check if we've actually canceled the context, and if so — ignore the error from the underlying code.