Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Worker: do not report the task as failed if it's context was canceled #654

Merged
merged 1 commit into from
Sep 29, 2023
+1 −1
Merged

Worker: do not report the task as failed if it's context was canceled #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/worker/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func (worker *Worker) runTask(

err := inst.Run(taskCtx, &config)

if err != nil && !errors.Is(err, context.Canceled) {
if err != nil && !errors.Is(err, context.Canceled) && !errors.Is(taskCtx.Err(), context.Canceled) {
worker.logger.Errorf("failed to run task %d: %v", agentAwareTask.TaskId, err)

boundedCtx, cancel := context.WithTimeout(context.Background(), perCallTimeout)
Expand Down