This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Align feature class naming to a new scheme. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/imagetextalternative.js # tests/image/imageediting.js # tests/imagecaption/imagecaptionediting.js # tests/imagetextalternative.js
|
I might have messed up something during merge with master, but here are my doubts: https://github.com/ckeditor/ckeditor5-image/blob/t/ckeditor5/488/src/image.js#L50-L56 Is this supposed to be here? Doesn't it touch UI? Shouldn't it be somewhere where image toolbar is declared ( I don't know if I like that there is some UI stuff here. For example: icons. Shouldn't it be moved to |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Align feature class naming to a new scheme.
BREAKING CHANGE: Renamed
ImageEnginetoImageEditing.BREAKING CHANGE: Extracted
ImageUIfromImage.BREAKING CHANGE: Renamed
ImageStyleEnginetoImageStyleEditing.BREAKING CHANGE: Extracted
ImageStyleUIfromImageStyle.BREAKING CHANGE: Renamed
ImageTextAlternativeEnginetoImageTextAlternativeEditing.BREAKING CHANGE: Extracted
ImageTextAlternativeUIfromImageTextAlternative.Additional information