Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GHS + PFO: pasting table from Google Sheets displays HTML comment #14131

Closed
mmotyczynska opened this issue May 12, 2023 · 3 comments · Fixed by #14136
Closed

GHS + PFO: pasting table from Google Sheets displays HTML comment #14131

mmotyczynska opened this issue May 12, 2023 · 3 comments · Fixed by #14136
Assignees
Labels
package:html-support package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mmotyczynska
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Add PasteFromOffice to ghs-all-features manual test.
  2. Change config for GHS:
htmlSupport: {
	allow: [
		{
			name: /^(table|thead|tbody|td|th|tr|col|colgroup)$/,
			styles: true,
		},
	],
},
  1. Paste a table from Google Sheets.

✔️ Expected result

The table is displayed in the editor.

❌ Actual result

Besides the table, there is also an HTML comment displayed above.
image

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mmotyczynska mmotyczynska added type:bug This issue reports a buggy (incorrect) behavior. package:paste-from-office package:html-support labels May 12, 2023
@filipsobol filipsobol self-assigned this May 12, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 12, 2023
@filipsobol filipsobol added the squad:core Issue to be handled by the Core team. label May 12, 2023
arkflpc added a commit that referenced this issue May 24, 2023
…n-pasting-table-from-google-sheets

Fix (paste-from-office): Remove the `<style>` tag that comes with the table pasted from Google Sheets. Closes #14131.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 24, 2023
@CKEditorBot CKEditorBot added this to the iteration 64 milestone May 24, 2023
@ethan-rally
Copy link

It didn't fixed on neither v38.0.0 nor v38.0.1

@filipsobol
Copy link
Member

@ethan-rally This issue will be fixed in v39.0.0. I confused this task with another and accidentally changed the iteration from 64 (v39) to 63 (v38). I have changed the iteration back to 64 to properly reflect which version contains the fix.

@ethan-rally
Copy link

Thank you so much for the update. When it ( v39 ) is going to be released ? This issue was a blocker for us to upgrade v38, since v37 didn't have a issue like this. Do you have any ETA for v39 ?

@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Jun 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
package:html-support package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants