Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Documenting different behavior of list vs. document lists. #15675

Closed
Witoso opened this issue Jan 11, 2024 · 1 comment
Closed

Documenting different behavior of list vs. document lists. #15675

Witoso opened this issue Jan 11, 2024 · 1 comment
Assignees
@godai78
Labels
squad:core Issue to be handled by the Core team. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 70 (v41...

Comments

@Witoso
Copy link
Member

Witoso commented Jan 11, 2024

Provide a description of the task

In the old lists, now LegacyList it was possible to create the same list type but with different properties, and they didn't merge.

Screen.Recording.2024-01-11.at.09.06.36.mov

Document list merges such lists items. It's possible to load AdjacentListsSupport but it will only work on the data load or paste, not from the UI.

We tried to collect feedback #14478, but we haven't decided yet.

The impact of replacing the lists' implementation (#14767) may be visible if users had such lists (data change). Keep in mind we also switched transparently the implementation of predefined builds.

But this could serve us as a valuable moment of feedback gathering, as after numerous discussion we haven't reached final verdict.

Action items:

  • inform in the update guide about that the change happened in the predefined builds.
  • link in the update guide the issue for adjacent lists to collect feedback.

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@Witoso Witoso added type:task This issue reports a chore (non-production change) and other types of "todos". release:potential-blocker This issue potentially blocks the upcoming release (should be checked). labels Jan 11, 2024
@godai78 godai78 self-assigned this Jan 11, 2024
@godai78 godai78 mentioned this issue Jan 11, 2024
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 11, 2024
@godai78 godai78 added type:docs This issue reports a task related to documentation (e.g. an idea for a guide). squad:core Issue to be handled by the Core team. labels Jan 11, 2024
godai78 added a commit that referenced this issue Jan 11, 2024
@godai78
Merge pull request #15676 from ckeditor/ck/15675
163efa9 
Docs: adding new merging lists behavior to update guide. Closes #15675
@godai78 godai78 closed this as completed Jan 11, 2024
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 11, 2024
@Witoso
Copy link
Member Author

Witoso commented Jan 12, 2024

Opening to show others on TP review.

@Witoso Witoso reopened this Jan 12, 2024
@pomek pomek removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Jan 12, 2024
@Witoso Witoso closed this as completed Jan 12, 2024
@Witoso Witoso added the resolution:resolved This issue was already resolved (e.g. by another ticket). label Jan 12, 2024
@Witoso Witoso added this to the iteration 70 milestone Jan 12, 2024
@Witoso Witoso removed the resolution:resolved This issue was already resolved (e.g. by another ticket). label Jan 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@godai78 godai78

Labels
squad:core Issue to be handled by the Core team. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 70 (v41.0.0)
Development

No branches or pull requests
4 participants
@pomek @Witoso @CKEditorBot @godai78