Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Visual glitches while editing an image using CKBox #16153

Closed
oleq opened this issue Apr 3, 2024 · 2 comments · Fixed by #16348 or Klantinteractie-Servicesysteem/KISS-frontend#929
Closed
Labels
package:ckbox package:image type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Apr 3, 2024

📝 Provide detailed reproduction steps (if any)

Screen.Recording.2024-04-03.at.11.27.56.mov

✔️ Expected result

  1. The loading spinner in CKBox staying centered.
  2. The image toolbar staying attached to the image after closing CKBox.

📃 Other details

  • Browser: Chrome
  • OS: MacOS

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. release:potential-blocker This issue potentially blocks the upcoming release (should be checked). package:image type:regression This issue reports a bug that was not present in the previous releases. package:ckbox labels Apr 3, 2024
@DawidKossowski DawidKossowski removed the type:regression This issue reports a bug that was not present in the previous releases. label Apr 3, 2024
@pomek pomek removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Apr 4, 2024
@gorzelinski gorzelinski reopened this Apr 5, 2024
@gorzelinski
Copy link
Contributor

I've investigated these problems a little.

  1. The spinner is probably only related to this one particular example. I guess there is a CSS conflict of some sort.
  2. The problem with the toolbar might be more broad. I tested some other demos with CKBox image editing enabled, and the results were the same. It may be related to the position: fixed property. When you turn it off on the CKBox dialog, the toolbar works correctly. It also fixes itself after some action on the page, like scrolling or clicking it. The toolbar is misplaced for 100px from the top.

Examples of other demos with the second problem:

@oleq
Copy link
Member Author

oleq commented May 7, 2024

2. The problem with the toolbar might be more broad. I tested some other demos with CKBox image editing enabled, and the results were the same. It may be related to the position: fixed property. When you turn it off on the CKBox dialog, the toolbar works correctly. It also fixes itself after some action on the page, like scrolling or clicking it. The toolbar is misplaced for 100px from the top.

We may want to call editor.ui.update() when CKBox closes. Various parts of the editor UI (including BalloonToolbar) react to that and re-position themselves.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
package:ckbox package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
5 participants