Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The FormHeaderView comoponent needs some refactoring and clean-up #6507

Closed
4 tasks done
oleq opened this issue Mar 27, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-ui#550
Closed
4 tasks done

The FormHeaderView comoponent needs some refactoring and clean-up #6507

oleq opened this issue Mar 27, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-ui#550
Assignees
@panr
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 31 (v19...

Comments

@oleq
Copy link
Member

oleq commented Mar 27, 2020 •
edited by panr
Loading

Provide a description of the task

A follow-up of #6109.

cc @jodator
@oleq oleq added the type:task This issue reports a chore (non-production change) and other types of "todos". label Mar 27, 2020
@oleq oleq added this to the iteration 31 milestone Mar 27, 2020
@jodator
Copy link
Contributor

jodator commented Mar 27, 2020

Ugh :( sorry for that. I'll read those changes to know those CSS better.

This was referenced Mar 30, 2020
Merged
Merged
Merged
@panr
Copy link
Contributor

panr commented Mar 30, 2020 •
edited
Loading

OK, made the changes.

but then the options.label is optional. Why?

I took this a little further 🙈Made label view fully optional (see minor breaking changes — ckeditor/ckeditor5-ui#550 (comment)). Waiting for the feedback @oleq ;-)

oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 1, 2020
@oleq
Merge pull request #292 from ckeditor/i/6507
9fffd07 
Internal: Removed an orphan stylesheet for a private form header component that has been moved to ckeditor5-ui in the past (see ckeditor/ckeditor5#6507).
oleq added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Apr 3, 2020
@oleq
Merge pull request #275 from ckeditor/i/6507
44bc474 
Internal: Moved part of the form header component styling from ckeditor5-ui to the theme (see ckeditor/ckeditor5#6507).
oleq added a commit to ckeditor/ckeditor5-ui that referenced this issue Apr 3, 2020
@oleq
Merge pull request #550 from ckeditor/i/6507
5d86638 
Internal: Cleaned up the FormHeaderView docs and code. Closes ckeditor/ckeditor5#6507.
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #275 from ckeditor/i/6507
06f98fe 
Internal: Moved part of the form header component styling from ckeditor5-ui to the theme (see #6507).
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #550 from ckeditor/i/6507
948ff4d 
Internal: Cleaned up the FormHeaderView docs and code. Closes #6507.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@panr panr

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

I/6507: Clean up the form header component ckeditor/ckeditor5-ui
3 participants
@jodator @oleq @panr