Hide document outline and annotations when entering source editing mode #17979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawidKossowski
approved these changes
Mar 4, 2025
| */ | ||
| private _refreshAnnotationsVisibility() { | ||
| if ( this.editor.plugins.has( 'Annotations' ) ) { | ||
| ( this.editor.plugins.get( 'Annotations' ) as Annotations ).refreshVisibility(); |
There was a problem hiding this comment.
Do we need the casting here?
There was a problem hiding this comment.
It's funny, actually. If I remove the casting but leave the unused Annotations import, it still works. But without import, TS is no longer able to connect the dots. I think it's clearer to leave casting here than unused import.
Base automatically changed from
ck/fullscreen-bootstrap
to
ck/epic/1235-fullscreen-mode
March 5, 2025 09:53
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (source-editing): Hide document outline and annotations when entering source editing mode. Closes #17978.
Internal (fullscreen): Display source editing with the same container width as editable.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.