Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Renamed contextual/contextualtoolbar~ContextualToolbar to balloon/balloontoolbar~BalloonToolbar. #856

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Feb 16, 2018

Suggested merge commit message (convention)

Aligned docs after ranaming ContextualToolbar to BallonToolbar.


Other: Rename ContextualToolbar to BalloonToolbar. Closes #ckeditor/ckeditor5/550.

Additional information

Updated repositories that uses above mentioned toolbar are:

Proposed merge message for those branches:

Aligned code after ranaming ContextualToolbar to BallonToolbar.

but for: https://github.com/ckeditor/ckeditor5-ui/tree/t/ckeditor5/550:

Other: Rename `ContextualToolbar` to `BalloonToolbar`.  Closes ckeditor/ckeditor5#550.

BREAKING CHANGE: Renamed `contextual/contextualtoolbar~ContextualToolbar` to `balloon/balloontoolbar~BalloonToolbar`.
BREAKING CHANGE: Renamed `contextualToolbar` configuration option to `balloonToolbar`.

@jodator jodator requested a review from Reinmar February 16, 2018 11:06
@Reinmar Reinmar merged commit d01d1a2 into master Feb 21, 2018
@Reinmar Reinmar deleted the t/550 branch February 21, 2018 11:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants