Skip to content

[inspector] Add analytics and table view-mode #3802

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Apr 5, 2025

Sister PRs: clojure-emacs/orchard#331, clojure-emacs/orchard#332, clojure-emacs/cider-nrepl#927, clojure-emacs/cider-nrepl#928

Small touches to enable the features that are implemented inside Orchard.

Here's how that first-time analytics hint looks like:
image


  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

@alexander-yakushev alexander-yakushev force-pushed the analytics-and-table-mode branch 2 times, most recently from 9931aef to 9081f85 Compare April 5, 2025 14:29
@alexander-yakushev alexander-yakushev force-pushed the analytics-and-table-mode branch from 9081f85 to abf49a0 Compare April 5, 2025 14:47
@@ -36,10 +36,6 @@ You'll have access to additional keybindings in the inspector buffer
| `cider-inspector-next-inspectable-object`
| Navigate inspectable sub-objects

| kbd:[f] and kbd:[b]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were those removed?

Copy link
Member Author

@alexander-yakushev alexander-yakushev Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I decided this binding is too standard and obvious to be listed here, and we already have too many bindings to communicate to the user.

Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alexander-yakushev alexander-yakushev merged commit 4b175e6 into master Apr 7, 2025
18 checks passed
@alexander-yakushev alexander-yakushev deleted the analytics-and-table-mode branch April 7, 2025 08:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants