Skip to content

[inspect] Add :table view-mode #331

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Apr 4, 2025

Another big feature for the inspector that has been requested before and will make some people's lives better.

We already have the concept of a "view mode" that currently switches between :normal and :object (force-showing Java object fields instead of custom rendering).

A new view-mode called :table can also be cycled through using the same v keybinding.

  • Table view mode works for sequences of maps or tuples.
  • Supports paging.
  • All elements inside the table are clickable/navigable!
  • There are some minor lackings, like path is not recorded if you navigate through the table, but it can be fixed later.

Here's how the end result looks:

image image image
  • You've added tests to cover your change(s)
  • You've updated the changelog (if adding/changing user-visible functionality)

Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this!

Great work! 🙇‍♂️

@alexander-yakushev alexander-yakushev merged commit cc707b2 into master Apr 5, 2025
20 checks passed
@alexander-yakushev alexander-yakushev deleted the table-view-mode branch April 5, 2025 12:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants