Update VW and Data Viz api parameters #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Enright <jenright@cloudera.com>
Signed-off-by: Jim Enright <jenright@cloudera.com>
github-actions
bot
added
validated
wmudge
requested changes
Jan 9, 2025
| @@ -356,7 +358,7 @@ def main(): | |||
| id=dict(type="str"), | |||
| name=dict(type="str"), | |||
| config=dict(type="dict"), | |||
| template_name=dict(type="str"), | |||
| template_name=dict(type="str", aliases=["resource_template"]), | |||
There was a problem hiding this comment.
Let's swap these -- the old name should be the alias
| @@ -71,13 +71,17 @@ | |||
| - Required if C(state=present) | |||
| type: str | |||
| template: | |||
| description: The name of deployment template for the Virtual Warehouse | |||
| description: | |||
| - The name of deployment T-shirt size to use. | |||
There was a problem hiding this comment.
Maybe reference the "deployment template" as an aside ("i.e. the deployment template")
| @@ -600,7 +604,11 @@ def main(): | |||
| catalog_id=dict(type="str", aliases=["dbc_id"]), | |||
| type=dict(type="str"), | |||
| name=dict(type="str"), | |||
| template=dict(type="str", choices=["xsmall", "small", "medium", "large"]), | |||
| template=dict( | |||
Signed-off-by: Jim Enright <jenright@cloudera.com>
github-actions
bot
added
validated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the release of version 0.9.128 of the CDP CLI and API some CDW related parameters have been renamed:
templatehas been renamed totShirtSize. API Docs LinktemplateNamehas been renamed toresourceTemplate. API Docs LinkThis PR handles the parameter renaming in the cloudera.cloud Ansible collection. Requires cloudera-labs/cdpy#106