Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update VW and Data Viz api parameters #167

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Update VW and Data Viz api parameters #167

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5209e64
Update VW and Data Viz api parameters
jimright Jan 7, 2025
dc6d405
Fix lint issues
jimright Jan 7, 2025
49a4c3b
Resolve PR feedback
jimright Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions plugins/modules/dw_data_visualization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,10 @@
description: Version of the Cloudera Data Visualization.
type: str
template_name:
description: The template size for the Cloudera Data Visualization.
description: The name of the available resource template to use for the Cloudera Data Visualization.
type: str
aliases:
- resource_template
wait:
description:
- Flag to enable internal polling to wait for the Data Visualization Instance to achieve the declared state.
Expand Down Expand Up @@ -327,7 +329,7 @@ def process(self):
cluster_id=self.cluster["id"],
name=self.name,
config=self.config,
template_name=self.template_name,
resource_template=self.template_name,
image_version=self.image_version,
)
if self.wait:
Expand Down Expand Up @@ -356,7 +358,7 @@ def main():
id=dict(type="str"),
name=dict(type="str"),
config=dict(type="dict"),
template_name=dict(type="str"),
template_name=dict(type="str", aliases=["resource_template"]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's swap these -- the old name should be the alias

image_version=dict(type="str"),
state=dict(type="str", choices=["present", "absent"], default="present"),
wait=dict(type="bool", default=True),
Expand Down
14 changes: 11 additions & 3 deletions plugins/modules/dw_virtual_warehouse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,17 @@
- Required if C(state=present)
type: str
template:
description: The name of deployment template for the Virtual Warehouse
description:
- The name of deployment T-shirt size to use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reference the "deployment template" as an aside ("i.e. the deployment template")

- This will determine the number of nodes.
type: str
choices:
- xsmall
- small
- medium
- large
aliases:
- tshirt_size
autoscaling:
description:
- Auto-scaling configuration for a Virtual Warehouse
Expand Down Expand Up @@ -546,7 +550,7 @@ def process(self):
dbc_id=self.dbc_id,
vw_type=self.type,
name=self.name,
template=self.template,
tshirt_size=self.template,
autoscaling_min_cluster=self.autoscaling_min_nodes,
autoscaling_max_cluster=self.autoscaling_max_nodes,
autoscaling_auto_suspend_timeout_seconds=self.autoscaling_auto_suspend_timeout_seconds,
Expand Down Expand Up @@ -600,7 +604,11 @@ def main():
catalog_id=dict(type="str", aliases=["dbc_id"]),
type=dict(type="str"),
name=dict(type="str"),
template=dict(type="str", choices=["xsmall", "small", "medium", "large"]),
template=dict(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also swap the two

type="str",
choices=["xsmall", "small", "medium", "large"],
aliases=["tshirt_size"],
),
autoscaling=dict(
type="dict",
options=dict(
Expand Down
Loading