Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

dns: do not parse JSON when response is not ok #3331

Merged
merged 1 commit into from
Jan 14, 2025
Merged

dns: do not parse JSON when response is not ok #3331

merged 1 commit into from
Jan 14, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 13, 2025

/cc @anonrig

@vicb vicb requested review from a team as code owners January 13, 2025 20:20
@vicb vicb requested review from anonrig and vickykont January 13, 2025 20:20
@vicb vicb force-pushed the vicb/dns-fetch-error branch from 28d9219 to 1578eaf Compare January 14, 2025 07:08
@vicb
Copy link
Contributor Author

vicb commented Jan 14, 2025

@anonrig I have addressed the feedback, could you please merge if this looks good.

Thanks

@anonrig anonrig merged commit c682991 into cloudflare:main Jan 14, 2025
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

@vickykont vickykont Awaiting requested review from vickykont vickykont is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicb @jasnell @anonrig