Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI] Fix minor dependency vulnerability, fix CLA job running when closing a PR #3424

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Jan 29, 2025

  • GitHub warns about an outdated dependency (idna Rust crate) being vulnerable. This is only used as a transitive dependency in a sample however – update Rust deps for the sample to fix this.
  • The CLA check CI job ran when closing a PR so far, leading to a confusing comment when closing a PR that would not pass the CLA job even though the point of CLA passing is now moot. Accordingly, we should only run the CLA when opening or synchronizing a PR.

I manually confirmed that the sample still works.

@fhanau fhanau requested review from a team as code owners January 29, 2025 00:43
@fhanau fhanau requested review from anonrig and a-robinson January 29, 2025 00:43
…sing a PR

- GitHub warns about an outdated dependency (idna Rust crate) being vulnerable.
  This is only used as a transitive dependency in a sample however – update
  Rust deps for the sample to fix this.
- The CLA check CI job ran when closing a PR so far, leading to a confusing
  comment when closing a PR that would not pass the CLA job even though the
  point of CLA passing is now moot. Accordingly, we should only run the CLA when
  opening or synchronizing a PR.
@fhanau fhanau force-pushed the felix/012825-ci-maintenance branch from 458f9bd to 7342ece Compare January 29, 2025 00:44
@fhanau fhanau merged commit a21848c into main Jan 29, 2025
17 checks passed
@fhanau fhanau deleted the felix/012825-ci-maintenance branch January 29, 2025 02:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants