use bazel6 #361
Merged
use bazel6 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
approved these changes
Feb 9, 2023
mikea
force-pushed
the
maizatskyi/2023-02-09-bazel6
branch
from
97038a9 to
c8875c8
Compare
fhanau
force-pushed
the
maizatskyi/2023-02-09-bazel6
branch
from
c8875c8 to
3da2605
Compare
|
Rebased to latest main branch and all tests pass locally on mac – let's see if the same applies for CI |
fhanau
force-pushed
the
maizatskyi/2023-02-09-bazel6
branch
from
3da2605 to
3e29486
Compare
|
Created a patch that fixes mac compilation, but as far as I can see upstream v8 includes a different fix for the issue, so it won't be needed. Let's wait for #437 to be merged and then switch to bazel v6. |
fhanau
force-pushed
the
maizatskyi/2023-02-09-bazel6
branch
from
3e29486 to
69ac2df
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this matches what we use internally