bazel: Reuse sandbox directories #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/bazel-reuse-sandbox
branch
from
aaf28b8 to
f31420b
Compare
fhanau
force-pushed
the
felix/bazel-reuse-sandbox
branch
from
f31420b to
34ebf6e
Compare
mikea
approved these changes
Mar 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reuse_sandbox_directories should be a flag worth using in all cases. While there is scant documentation the only potential issue with it I was able to find is bazel #17310 (resolved on upstream bazel but not yet released, unlikely to affect us though). It is a non-experimental option since bazel v6.
The flag significantly reduces the sandbox setup/teardown overhead and provides a large compilation speedup on M1 macOS and a noticeable speedup on Linux x86, especially on systems with slow disk I/O (based on Orion's testing), it should be worth enabling globally.
Let's merge this once we have integrated #361, that way we can use the non-experimental flag. I can gather some additional performance metrics at that time.