Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use cloudflare TS bundle in workerd-api. #569

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Use cloudflare TS bundle in workerd-api. #569

merged 1 commit into from
Apr 26, 2023

Conversation

dom96
Copy link
Collaborator

@dom96 dom96 commented Apr 25, 2023

This makes import { connect } from 'cloudflare:sockets'; work in workerd.

Test Plan

$ bazel run @workerd//src/workerd/server:workerd -- serve $PWD/deps/workerd/samples/tcp/config.capnp --watch --verbose --experimental
$ curl localhost:8080

@dom96 dom96 force-pushed the dominik/move-ts-to-workerd branch 2 times, most recently from 66991e8 to e5d1169 Compare April 25, 2023 16:43
mikea
mikea reviewed Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@mikea mikea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't see this before but we should try to use wd_ts_bundle. Ping me if you have questions/problems with it.

ts/tsconfig.base.json Outdated Show resolved Hide resolved
build/wd_ts_project_embed.bzl Outdated Show resolved Hide resolved
ts/node/path.ts Outdated Show resolved Hide resolved
@dom96 dom96 force-pushed the dominik/move-ts-to-workerd branch 2 times, most recently from ffef455 to 3876766 Compare April 26, 2023 10:50
@dom96 dom96 changed the title Add ew files for typescript project embeds. Use cloudflare TS bundle in workerd-api. Apr 26, 2023
@dom96 dom96 force-pushed the dominik/move-ts-to-workerd branch from 3876766 to 48d03d0 Compare April 26, 2023 11:05
@dom96 dom96 merged commit f39f114 into main Apr 26, 2023
@dom96 dom96 deleted the dominik/move-ts-to-workerd branch April 26, 2023 16:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mikea mikea mikea approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dom96 @mikea @jasnell