-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
MTD reconstruction and validation: update TkFilterParameters in MTD use with Phase2 settings #47351
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47351/43691 |
A new Pull Request was created by @fabiocos for master. It involves the following packages:
@Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bugfix |
type mtd |
please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
+1 |
+1 |
+Upgrade |
+dqm
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Both the producer of root-ples to train MVA models for MTD, in
RecoMTD/TimingIDTools
, and thePrimary4DVerticesValidation
class inValidation/MtdValidation
import theTkFilterParameters
PSet fromRecoVertex/PrimaryVertexProducer
. It needs to be used in its Phase2 setting, in particular enlarging the eta acceptance.This PR fixes the missing customisation in both cases.
PR validation:
Expanded config files produced with this update produce the desired configuration. Standalone cfg configurations for both
mvaTrainingSaveNtuple_cfg.py
andmtdValidation_cfg.py
are updated accordingly.