Replace exit(x) with return x in ROOT macros

[iarspider]

PR description:

As recommended by @pcanal in #47376 (comment)

PR validation:

Bot tests

[iarspider]

please test for CMSSW_15_1_ROOT6_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47391/43772

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47391/43772/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47391/43772/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47391/43773

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/FWLite (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for CMSSW_15_1_ROOT6_X

[iarspider]

There are some other macros that use exit instead of return, I think they should be updated as well.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcc561/44490/summary.html
COMMIT: 99ce3f0
CMSSW: CMSSW_15_1_ROOT6_X_2025-02-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47391/44490/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Run3-gex187B Correct the payload creation scripts for the years 2024 and 2025 #47365
• @mmusich make edmConfigFromDB exit with an error message #47369
• @bsunanda Run3-gex187D Update some of the geometry cff's of Run2 period #47371
• @AdrianoDee Fixing RelMon Pages Stylesheets Locations #47382
• @bsunanda Run3-gex187F Update the remaining scriptts in Configuration/Geometry for Calorimeter and Muon systems #47380
• @fwyzard Fix warning about implicitly-declared copy constructor #47356
• @bsunanda Run3-gex187G Modify the scripts to prepare the DDD payloads for the Run2 scenarios #47381
• @Dr15Jones Have fillDescriptions generate a template for VPSet in cfi files #47374
• @bsunanda Run3-gex187C Update the scripts for the years 2021, 2023, 2024, 2026 which are used to prepare the payloads from DDD versions #47366
• @artlbv [Phase-2 L1]: update readme for P2GT menu configs #47282
• @mmusich fix throwOnMissing logic in ObjectSelectorBase #47359
• @AdrianoDee Adding SimpleTrackValidation Analyzer #47370
• @brunolopesbr2 Updated HLT BTV validation paths from DeepCSV to PNet #47344
• @bsunanda Run3-gex187E Update several geometry scripts for misc. Extended scenarios #47375
• @iarspider Fix improper use of std::unique and std::remove #47320
• @iarspider [GCC14] Fix compilation errors #47330
• @rovere Remove unused L1T paths from the past from HLT Upgrade Menu. #47379
• @KIT-CMS Embedding update for run3 #47299
• @fabiocos MTD reconstruction and validation: update TkFilterParameters in MTD use with Phase2 settings #47351
• @mmusich add IT and OT cluster, rechit and tracking rechits validation at HLT for Phase-2 #47352
• @vlimant add a filter sequence if it is present in the fragment #47335

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcc561/44490/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcc561/44490/git-merge-result

Comparison Summary

Summary:

• You potentially added 223 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 1000 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3902732
• DQMHistoTests: Total failures: 449
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3902261
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 109179.54199999999 KiB( 48 files compared)
• DQMHistoSizes: changed ( 16834.0,... ): -1686.929 KiB HLT/BTV
• DQMHistoSizes: changed ( 24834.911,... ): 13600.762 KiB HLT/TrackerPhase2OTTrackingRecHitV
• DQMHistoSizes: changed ( 24834.911,... ): 2468.031 KiB HLT/TrackerPhase2ITTrackingRecHitV
• DQMHistoSizes: changed ( 24834.911,... ): 2464.594 KiB HLT/TrackerPhase2ITRecHitV
• DQMHistoSizes: changed ( 24834.911,... ): 183.994 KiB HLT/TrackerPhase2OTClusterV
• DQMHistoSizes: changed ( 24834.911,... ): 41.480 KiB HLT/TrackerPhase2ITClusterV
• DQMHistoSizes: changed ( 24834.911,... ): 0.020 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 24834.911,... ): 0.020 KiB MessageLogger/Warnings
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: found differences in 6 / 47 workflows

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47391/43785

[cmsbuild]

Pull request #47391 was updated.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47391/43786

[cmsbuild]

Pull request #47391 was updated.

[iarspider]

please abort

[iarspider]

please test for CMSSW_15_1_ROOT6_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcc561/44507/summary.html
COMMIT: a157fa1
CMSSW: CMSSW_15_1_ROOT6_X_2025-02-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47391/44507/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 225 lines to the logs
• Reco comparison results: 941 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3919988
• DQMHistoTests: Total failures: 499
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3919469
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found