Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

protect Phase2IT{OT}ValidateCluster against missing input collections #47398

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 19, 2025

PR description:

Title says it all, addresses discussion at #47352 (comment) by including protections against missing cluster collections inputs in Phase2IT{OT}ValidateCluster.

PR validation:

runTheMatrix.py -l 24034.0 -t 4 -j 8 --ibeos now runs OK.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Feb 19, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 19, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 19, 2025

test parameters:

  • workflow = 24034.0

@mmusich mmusich force-pushed the mm_protect_ITadnOTClusterValidators branch from cc2c872 to f3e0943 Compare February 19, 2025 08:08
@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Feb 19, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Validation/SiTrackerPhase2V (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@arossi83, @missirol, @richa2710, @sroychow this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06ea50/44501/summary.html
COMMIT: f3e0943
CMSSW: CMSSW_15_1_X_2025-02-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47398/44501/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24034.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 101 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3919988
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3919920
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 217 log files, 188 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants