Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add IT and OT cluster, rechit and tracking rechits validation at HLT for Phase-2 #47352

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 14, 2025

PR description:

Title says it all.

PR validation:

runTheMatrix.py -l 29634.0 -t 4 -j 8 runs fine, and produces the desired plots.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 14, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTriggerOffline/Common (dqm)
  • Validation/SiTrackerPhase2V (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@arossi83, @missirol, @mtosi, @richa2710, @sroychow this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 14, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-81c39a/44391/summary.html
COMMIT: 049e9a5
CMSSW: CMSSW_15_1_X_2025-02-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47352/44391/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3905432
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3905386
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 112553.4 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 24834.911,... ): 13600.762 KiB HLT/TrackerPhase2OTTrackingRecHitV
  • DQMHistoSizes: changed ( 24834.911,... ): 2468.031 KiB HLT/TrackerPhase2ITTrackingRecHitV
  • DQMHistoSizes: changed ( 24834.911,... ): 2464.594 KiB HLT/TrackerPhase2ITRecHitV
  • DQMHistoSizes: changed ( 24834.911,... ): 183.994 KiB HLT/TrackerPhase2OTClusterV
  • DQMHistoSizes: changed ( 24834.911,... ): 41.480 KiB HLT/TrackerPhase2ITClusterV
  • DQMHistoSizes: changed ( 24834.911,... ): 0.020 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 24834.911,... ): 0.020 KiB MessageLogger/Warnings
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b8776f5 into cms-sw:master Feb 18, 2025
11 checks passed
@antoniovilela
Copy link
Contributor

@mmusich

We got these in the IB:

----- Begin Fatal Exception 18-Feb-2025 15:55:31 CET-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing Event run: 1 lumi: 1 event: 4 stream: 1
[1] Running path 'prevalidation_step8'
[2] Calling method for module Phase2ITValidateCluster/'hltClusterValidIT'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edmNew::DetSetVector
Looking for module label: hltSiPixelClusters
Looking for productInstanceName:

----- Begin Fatal Exception 18-Feb-2025 15:55:31 CET-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing Event run: 1 lumi: 1 event: 3 stream: 0
[1] Running path 'prevalidation_step8'
[2] Calling method for module Phase2OTValidateCluster/'hltClusterValidOT'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edmNew::DetSetVector
Looking for module label: hltSiPhase2Clusters
Looking for productInstanceName:

@mmusich
Copy link
Contributor Author

mmusich commented Feb 18, 2025

@antoniovilela

We got these in the IB:

I suppose you are referring to https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_15_1_NONLTO_X_2025-02-18-1100/pyRelValMatrixLogs/run/24034.0_TTbar_14TeV+Run4D96/step3_TTbar_14TeV+Run4D96.log#/.

The DQM monitoring modules should be protected against missing input, though it should be clarified why wf 24034.0 runs the @fake2 menu.

@antoniovilela
Copy link
Contributor

@antoniovilela

We got these in the IB:

I suppose you are referring to https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_15_1_NONLTO_X_2025-02-18-1100/pyRelValMatrixLogs/run/24034.0_TTbar_14TeV+Run4D96/step3_TTbar_14TeV+Run4D96.log#/.

Yes, all builds.

The DQM monitoring modules should be protected against missing input, though it should be clarified why wf 24034.0 runs the @fake2 menu.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 19, 2025

Yes, all builds.

@antoniovilela see #47398

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants