Delete outdated WL server and webpage source code #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtoven
requested review from
brendanww,
cb-jake,
hieronymus777 and
vishnumad
|
Looks like the We should update the |
|
Running yarn build:prod
cd build/npm
node
> require(".")
# output
{
WalletLinkProvider: [Getter],
WalletLink: [Getter],
default: [class WalletLink] { VERSION: '2.4.7' }
}
> .exitIt would be good to install this build into a dapp that uses walletlink to ensure no regressions but otherwise this looks good to me |
bangtoven
commented
Feb 9, 2022
| @@ -31,7 +31,7 @@ | |||
| "build-npm": "tsc -p ./tsconfig.build.json", | |||
| "build:dev": "export WALLETLINK_URL='http://localhost:3000'; yarn build && yarn build-chrome", | |||
| "build:dev:watch": "nodemon -e 'ts,tsx,js,json,css,scss,svg' --ignore 'src/**/*-css.ts' --ignore 'src/**/*-svg.ts' --watch src/ --watch chrome/ --exec 'yarn build:dev'", | |||
| "build:prod": "yarn prebuild && yarn build && yarn build-chrome && yarn build-npm && cp ./package.json ../README.md ../LICENSE build/npm && cp -a src/vendor-js build/npm/dist && sed -i.bak 's| \"private\": true,||g' build/npm/package.json && rm -f build/npm/package.json.bak", | |||
| "build:prod": "yarn prebuild && yarn build && yarn build-chrome && yarn build-npm && cp ./package.json ./README.md ./LICENSE build/npm && cp -a src/vendor-js build/npm/dist && sed -i.bak 's| \"private\": true,||g' build/npm/package.json && rm -f build/npm/package.json.bak", | |||
bangtoven
added a commit
that referenced
this pull request
Feb 29, 2024
* Delete outdated WL server and webpage source code * fix build:prod
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after
