Remove unused RxJS calls #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb-jake
reviewed
Jan 10, 2023
| @@ -48,19 +46,6 @@ export class Session { | |||
| return null; | |||
| } | |||
|
|
|||
| public static get persistedSessionIdChange$(): Observable<{ | |||
There was a problem hiding this comment.
what was this originally used for?
There was a problem hiding this comment.
@cb-jake i couldn't find any usages
There was a problem hiding this comment.
Sounds good, maybe @hieronymus777 has context?
There was a problem hiding this comment.
i did some digging, and it turned out this could have been deprecated along with this PR #319
this is a dead code
cb-jake
approved these changes
Jan 10, 2023
bangtoven
added a commit
that referenced
this pull request
Feb 29, 2024
bangtoven
added a commit
that referenced
this pull request
Aug 16, 2024
This was referenced Oct 11, 2024
This was referenced Oct 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test your changes?