Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[OPIK-656]: log experiments in the playground; #1072

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

aadereiko
Copy link
Contributor

Details

image image image

Issues

Resolves #

Testing

Documentation

@aadereiko aadereiko requested a review from a team as a code owner January 17, 2025 15:44
},
onCreateTraces: () => {
queryClient.invalidateQueries({
queryKey: [["projects"]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[["projects"]] -> ["projects"]

Comment on lines +39 to +44
processCurrentBatch();

if (flushTimer) {
clearTimeout(flushTimer);
flushTimer = null;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flushBatch()?

Copy link
Collaborator

@ferc ferc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work, code looks very clean for this complex functionality!

@ferc ferc merged commit e8beaa6 into main Jan 20, 2025
1 check passed
@ferc ferc deleted the sashaa/OPIK-656/log-experiments-in-playground branch January 20, 2025 10:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants