-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
2017 Pilot #159
Closed
vanillagorillaa
wants to merge
19
commits into
commaai:devel
from
vanillagorillaa:vanillagorillaa-pilot-port
Closed
2017 Pilot #159
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b0b2dc2
Add odyssey fingerprint
energee e043494
Add carstate changes
energee 272a24a
Add odyssey car params to interface
energee 775e4fa
Add carcontroller changes
energee 0790910
Add hondacan changes
energee 6e48bf6
Added entry to readme
energee b11598b
Merge pull request #1 from slesinski/odyssey-port
vanillagorillaa 73fa161
Update README.md
vanillagorillaa 7a15abc
Update carcontroller.py
vanillagorillaa 0314d56
Update carstate.py
vanillagorillaa f59cd6a
Update hondacan.py
vanillagorillaa d42ecba
Update interface.py
vanillagorillaa 70ec28f
Update carstate.py
vanillagorillaa e0eee59
Update hondacan.py
vanillagorillaa 807238b
Update carcontroller.py
vanillagorillaa 16551cf
Update carstate.py
vanillagorillaa 5aac267
Update fingerprints.py
vanillagorillaa 39a44c7
Update README.md
vanillagorillaa d289ed9
Update interface.py
vanillagorillaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these variable names are old. Looks like you need to rebase your branch with latest devel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rbiasini My branch is based off of @energee 's branch for easier merging of Odyssey port and Pilot Port. Would you rather have me change variable names in this PR or submit new PR with updated variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vanillagorillaa , up to you. You can either:
Since the 2 PR's should't intersect, maybe 1 is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rebase first