Easier car addition via some refactoring #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bitshop , since this PR is now including both the refactoring and the Tesla port, we should probably close |
|
I thought I closed this earlier; sorry about that.. |
mespiritu
pushed a commit
to mespiritu/openpilot
that referenced
this pull request
Apr 7, 2019
Update to latest release2
pd0wm
pushed a commit
that referenced
this pull request
Sep 10, 2019
684e28a honda bosch longitudinal (#185) cf9e14f Fix torque signal and add new CAN msgs (#181) f55a7ef Parking Assist Messages (#183) bfe982e Add FCA11 & SCC14 (#184) 3bfb39a Fix Spelling (#180) 7bb1e33 honda nidec AEB values 54d130e generated odyssey extreme 72dd171 run generator 45a5bc2 merge lexus IS and SI hybrid 8817a75 use generator for honda odyssey extreme d8c80d0 restore original toyota ref 0a97bc7 more honda bosch AEB signals beeaecf bosch AEB signals 7d309ec Add Subaru global transmission msg with gear values (#168) 7a25a5a Add DBC for JDM Honda Fit Hybrid 2018 (#178) a7e6c46 Updates and new signals (#177) git-subtree-dir: opendbc git-subtree-split: 684e28a
debugged-tech
referenced
this pull request
in debugged-tech/DebuggedPilot
Sep 14, 2020
Add fingerprint for modded 2015 Corolla with select upgraded 2017 ECU's and Pedal. Co-authored-by: vetmiker <vetmiker@gmail.com>
SebastienLubrano
pushed a commit
to SebastienLubrano/openpilot
that referenced
this pull request
Aug 9, 2021
mlocoteta
pushed a commit
to mlocoteta/openpilot
that referenced
this pull request
Jul 17, 2023
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this pull request
Aug 2, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored some of the Toyota work, made the fingerprint file use the CAR class (for Toyotas), moved around almost everything car specific to values.py, and added comments about how to add a car easier. There's far more that can be done, including getting this data from the DBC files, but now that it's in one place it's a small iteration easier for the community to understand.