Reapply "ui(raylib): create BaseWindow (#35074)" #35077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incognitojam
force-pushed
the
ui-raylib-window
branch
from
1ad75bb to
31505d7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR re-applies a previously reverted commit that introduced a new BaseWindow abstraction for UI windows, refactoring both the TextWindow and Spinner to benefit from common window management.
- Refactored TextWindow to subclass BaseWindow and implement _create_renderer.
- Refactored Spinner similarly to subclass BaseWindow and remove duplicated threading logic.
- Introduced a new BaseWindow in system/ui/lib/window.py to centralize window and threading functionality.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| system/ui/text.py | Refactors TextWindow to extend BaseWindow and simplify lifecycle management. |
| system/ui/spinner.py | Refactors Spinner to extend BaseWindow and removes custom thread management. |
| system/ui/lib/window.py | Adds BaseWindow that encapsulates common UI window threading and teardown logic. |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
incognitojam
force-pushed
the
ui-raylib-window
branch
from
6fed816 to
012d00e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 83b84a5.
Fixes issues with window title name and logging
This is only used for windows which need to be controlled programmatically.