Std cargo refactor #714
Closed
Std cargo refactor #714
+53
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. What about moving |
|
what do you think about moving hardcoded civic parameters into a class and adding functions for scaling tirestiffness and rotational inertia? |
|
yep, that would make sense, as long as such class has no dependencies, goes in init and it's super simple. Thanks for the STD_CARGO refactor |
|
merged internally due to conflicts. Will be in next release! |
aivordin
pushed a commit
to aivordin/openpilot
that referenced
this pull request
Mar 29, 2025
Convert safe_desired_curvature to float before returning. This ensures the returned value is explicitly a float, avoiding an issue when serializing it on capnp as it does not recognize numpy.float Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove mass unit ambiguities