Skip to content

refactor: misc cleanup #1428

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented May 17, 2025

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

@bearomorphism bearomorphism marked this pull request as ready for review May 17, 2025 12:45
Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (856ca4f) to head (07eaf84).
Report is 1 commits behind head on refactors.

Additional details and impacted files
@@              Coverage Diff              @@
##           refactors    #1428      +/-   ##
=============================================
- Coverage      97.78%   97.77%   -0.01%     
=============================================
  Files             57       57              
  Lines           2620     2612       -8     
=============================================
- Hits            2562     2554       -8     
  Misses            58       58              
Flag Coverage Δ
unittests 97.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels May 18, 2025
@bearomorphism bearomorphism mentioned this pull request May 25, 2025
10 tasks
@bearomorphism bearomorphism changed the base branch from master to refactors May 25, 2025 16:22
@Lee-W Lee-W merged commit d0db72c into commitizen-tools:refactors May 26, 2025
18 checks passed
@bearomorphism bearomorphism deleted the refactor-0517 branch June 1, 2025 05:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants