Skip to content

4.8.3 candidate #1457

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

4.8.3 candidate #1457

wants to merge 64 commits into from

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented May 25, 2025

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

@Lee-W
Copy link
Member Author

Lee-W commented May 25, 2025

Hey @woile @noirbizarre , I'd like to merge this one in the next few days. It contains all the PRs I reviewed this days to avoid bumping version too quickly

@Lee-W Lee-W changed the title Refactors 4.8.3 candidate May 25, 2025
Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (120d514) to head (a9cd957).
Report is 661 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   97.33%   97.87%   +0.53%     
==========================================
  Files          42       57      +15     
  Lines        2104     2677     +573     
==========================================
+ Hits         2048     2620     +572     
- Misses         56       57       +1     
Flag Coverage Δ
unittests 97.87% <100.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W
Copy link
Member Author

Lee-W commented May 25, 2025

@bearomorphism, please let us know if you want us to include anything in the next release. We'll try to review them

@bearomorphism
Copy link
Contributor

#1449

@bearomorphism
Copy link
Contributor

and probably #1453 which I'm fixing

@bearomorphism
Copy link
Contributor

and #1442
I'm resolving the conflict

@bearomorphism
Copy link
Contributor

#1428

@bearomorphism
Copy link
Contributor

Those are small PRs (<60 lines of code changes excluding tests). Thanks 🙇

@bearomorphism
Copy link
Contributor

And probably #1466

@Lee-W
Copy link
Member Author

Lee-W commented Jun 4, 2025

I hope to get it done this week... will try to review some more 💪

@Lee-W Lee-W marked this pull request as ready for review June 8, 2025 08:14
@Lee-W Lee-W requested review from woile and noirbizarre as code owners June 8, 2025 08:14
@bearomorphism
Copy link
Contributor

@Lee-W pls try merging #1509 to fix CI

@bearomorphism
Copy link
Contributor

bearomorphism commented Jun 8, 2025

@bearomorphism bearomorphism mentioned this pull request Jun 8, 2025
1 task
@bearomorphism
Copy link
Contributor

This commit is good
5a83aeb

@bearomorphism
Copy link
Contributor

@Lee-W please try #1513

@Lee-W
Copy link
Member Author

Lee-W commented Jun 8, 2025

I'm a damn idoit 🤦‍♂️

@Lee-W
Copy link
Member Author

Lee-W commented Jun 8, 2025

@bearomorphism I think i get it restored and push to this one

@bearomorphism
Copy link
Contributor

Please review the followings:

#1508
#1507
#1491
#1485
#1472
#1471
#1470

@bearomorphism
Copy link
Contributor

#1469

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants