Skip to content

refactor(cli): early return and improve test coverage #1449

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented May 23, 2025

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@a8094ae). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             refactors    #1449   +/-   ##
============================================
  Coverage             ?   97.82%           
============================================
  Files                ?       57           
  Lines                ?     2618           
  Branches             ?        0           
============================================
  Hits                 ?     2561           
  Misses               ?       57           
  Partials             ?        0           
Flag Coverage Δ
unittests 97.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism mentioned this pull request May 25, 2025
10 tasks
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. One minor question

@Lee-W Lee-W changed the base branch from master to refactors May 26, 2025 01:29
@Lee-W Lee-W added the pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check label May 26, 2025
@Lee-W Lee-W merged commit 83be38a into commitizen-tools:refactors May 26, 2025
18 checks passed
@bearomorphism bearomorphism deleted the refactor-cli branch June 1, 2025 05:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants