Skip to content

refactor(bump): eliminate similar patterns in code #1508

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Jun 7, 2025

Description

Checklist

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (a9cd957) to head (99bd410).
Report is 13 commits behind head on refactors.

Additional details and impacted files
@@              Coverage Diff              @@
##           refactors    #1508      +/-   ##
=============================================
+ Coverage      97.87%   97.90%   +0.03%     
=============================================
  Files             57       57              
  Lines           2677     2673       -4     
=============================================
- Hits            2620     2617       -3     
+ Misses            57       56       -1     
Flag Coverage Δ
unittests 97.90% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

out.write(c.err)
for msg in (c.out, c.err):
if msg:
(out.diagnostic if self.git_output_to_stderr else out.write)(msg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(out.diagnostic if self.git_output_to_stderr else out.write)(msg)
out_func_name = "diagnostic" if self.git_output_to_stderr else "write"
getattr(out, out_func_name)(msg)

This might be a bit easier to read 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc getattr does not have good type annotation. I prefer the following and still easy to read.

                out_func = out.diagnostic if self.git_output_to_stderr else out.write

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@bearomorphism bearomorphism mentioned this pull request Jun 8, 2025
10 tasks
@Lee-W Lee-W merged commit 52be917 into commitizen-tools:refactors Jun 8, 2025
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants