Skip to content

Restore old branch #1513

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 65 commits into from
Closed

Restore old branch #1513

wants to merge 65 commits into from

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Jun 8, 2025 •
edited
Loading

Description

git fetch origin 5a83aeb
git checkout -b restore-old-branch 5a83aeb
git rebase upstream/master -i
...
poetry lock

@bearomorphism @Lee-W
refactor: improve readability and fix typos
e4b048d
@bearomorphism @Lee-W
refactor(version_scheme): cleanup
3b4dbbc
@bearomorphism @Lee-W
refactor(commit): simplify call
77b3d4b
@bearomorphism @Lee-W
test(commit): when nothing is added to commit
7a1fb3e
@bearomorphism @Lee-W
refactor(git): code cleanup and better test coverage
b7e6a94
@bearomorphism @Lee-W
test(git): add test for from_rev_and_commit
262733a
@bearomorphism @Lee-W
docs(git): from_rev_and_commit docstring
bb63228
@bearomorphism @Lee-W
refactor(EOLType): add eol enum back and reorganize methods
8477b89
@bearomorphism @Lee-W
refactor(git): refactor get_tag_names
5810108
@bearomorphism @Lee-W
refactor(changelog): minor cleanup
3b163a8
@bearomorphism @Lee-W
refactor(BaseConfig): use setter
5cc58d9
@bearomorphism @Lee-W
build(poetry): upgrade mypy version to ^1.15.0
06970e6
@bearomorphism @Lee-W
refactor(bump): add type for out, replace function with re escape
d7efb1b
@bearomorphism @Lee-W
refactor(bump): clean up
1b9a177
@bearomorphism @Lee-W
test(bump): improve test coverage
2286271
@bearomorphism @Lee-W
fix(defaults): add non-capitalized default constants back and depreca…
360057b 
…ted warning

relates commitizen-tools#1446
@bearomorphism @Lee-W
refactor: misc cleanup
1ed9d2d
@bearomorphism @Lee-W
refactor(git): extract _create_commit_cmd_string
37a990b
@bearomorphism @Lee-W
test(test_git): mock os
5b94792
@bearomorphism @Lee-W
refactor(cli): early return and improve test coverage
1d7563e
@bearomorphism @Lee-W
build(termcolor): remove termcolor <3 restriction
978358a
@bearomorphism @Lee-W
build: specify importlib-metadata version to fix unit tests
2ccb269
@bearomorphism @Lee-W
refactor(changelog): better typing, yield
baee83e
@bearomorphism bearomorphism mentioned this pull request Jun 8, 2025
Merged
10 tasks
@codecov Codecov
Copy link

codecov bot commented Jun 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@c1884bd). Learn more about missing BASE report.

Additional details and impacted files 
@@             Coverage Diff              @@
##             refactors    #1513   +/-   ##
============================================
  Coverage             ?   97.87%           
============================================
  Files                ?       57           
  Lines                ?     2677           
  Branches             ?        0           
============================================
  Hits                 ?     2620           
  Misses               ?       57           
  Partials             ?        0
Flag Coverage Δ
unittests 97.87% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism
style: remove Union
7d40b04
@bearomorphism
style: better type
8287e17
@bearomorphism
style: add -> None to __init__
9b153b4
@bearomorphism
build(ruff,mypy): more strict rules
ee4646d
@bearomorphism
fix(BaseConfig): mypy error
21fae53
@bearomorphism
build(mypy): remove disallow_untyped_defs because it's already done b…
afcd5c3 
…y ruff rules
@bearomorphism
refactor(bump): TypedDict for bump argument
7ac3ea3
@bearomorphism
refactor(changelog): type untyped arguments
b7983ca
@bearomorphism
refactor(check): remove unused argument
b2a7a51
@bearomorphism
style(bump): rename class for consistency
db3c1a0
@bearomorphism
refactor(check): type CheckArgs arguments
4aed07c
@bearomorphism
refactor(commit): type commit args
5616076
@bearomorphism
refactor(commands): remove unused args, type version command args
735ad12
@bearomorphism
style(cli): shorten arg type
e2702fc
@bearomorphism
docs(bump): comment on a stupid looking pattern
e631941
@bearomorphism
fix(Check): make parameters backward compatiable
92bbab0
@bearomorphism
style(changelog): rename parameter for consistency
047779b
@bearomorphism
refactor(bump): improve readability and still bypass mypy check
945d0c3
@bearomorphism
refactor: remove unnecessary bool() and remove Any type from TypedDic…
2fa0452 
…t get
@bearomorphism
style(changelog): add TODO to fixable type ignores
022e552
@bearomorphism
style(cli): more specific type ignore
ba0c043
@bearomorphism
style(cli): rename kwarg to values
8a3a09b
@bearomorphism
refactor(bump): use any to replace 'or' chain
ff1a5ae
@bearomorphism
perf(bump): avoid unnecessary list construction and rename variable t…
e0cc9c4 
…o avoid confusion
@bearomorphism
ci: regenerate poetry lock
05ec0ba
@bearomorphism bearomorphism force-pushed the restore-old-branch-2 branch from 90fc4eb to 05ec0ba Compare June 8, 2025 10:25
@Lee-W
Copy link
Member

Lee-W commented Jun 8, 2025

Thanks for helping out on my damn stupid error 🤦‍♂️ I've just got it handled. close this one

@Lee-W Lee-W closed this Jun 8, 2025
@bearomorphism bearomorphism deleted the restore-old-branch-2 branch June 8, 2025 15:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@woile woile Awaiting requested review from woile

@Lee-W Lee-W Awaiting requested review from Lee-W

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees
No one assigned
Labels
pr-status: wait-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bearomorphism @Lee-W @gbaian10