Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix C++ package on Windows and add test that package is relocatable #25

Merged
merged 14 commits into from
Nov 15, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 15, 2022

Fix #18 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

As expected, the test on the existing repo is working on Linux/macOS and failing on Windows. Now we backport the fix from robotology/icub-models#179 to make it work on Windows as well.

@traversaro traversaro changed the title Fix C++ package on Windows and add test for relocatability Fix C++ package on Windows and add test that package is relocatable Nov 15, 2022
@traversaro
Copy link
Contributor Author

The backport of robotology/icub-models#179 fixed the test.

@traversaro traversaro merged commit 6ccbc64 into conda-forge:main Nov 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows prefix is not substituted in v1.23.4 build 0
2 participants