[CI:TOOLING] Fix skopeo image locale env. vars. #90
Conversation
Signed-off-by: Chris Evich <cevich@redhat.com>
|
Cirrus CI build successful. Image ID |
|
Note: I manually re-tagged and pushed the image as |
| ENV LANGUAGE="en_US" \ | ||
| LC_ALL="en_US" \ | ||
| LANG="en_US.UTF-8" | ||
| ENV LC_ALL="C" |
There was a problem hiding this comment.
This might break with non-ASCII characters. Values to consider are en_US.UTF-8 or perhaps C.UTF-8.
(I’m not following this closely, IIRC some of the locale data is not available in default installs, or default containers. I’d expect one of the two above (but _not necessarily en_US) to be available. Alternatively, the other locales might be available in packages named something like glibc-langpack*. Random googling finds containers/toolbox#60 and https://fedoraproject.org/wiki/Changes/Glibc_locale_subpackaging .)
There was a problem hiding this comment.
Oh, okay. Installing additional packages isn't a problem. Whatever's needed so the tests run smoothly.
There was a problem hiding this comment.
If C works fine, it’s not worth the effort/time to change it yet again for theoretical purity.
I vaguely remember Python in particular being not very happy with C + UTF-8, but that’s probably not relevant to us.
There was a problem hiding this comment.
Ya, this image is dedicated for skopeo. Anyway, yes I agree, if it's not a problem, no need to fix it. Thanks for your help/insight.
Signed-off-by: Chris Evich cevich@redhat.com