Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI:TOOLING] Fix skopeo image locale env. vars. #90

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[CI:TOOLING] Fix skopeo image locale env. vars. #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions skopeo_cidev/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ ARG BASE_TAG=latest
FROM ${BASE_NAME}:${BASE_TAG}

# Required to keep perl & other tooling happy
ENV LANGUAGE="en_US" \
LC_ALL="en_US" \
LANG="en_US.UTF-8"
ENV LC_ALL="C"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might break with non-ASCII characters. Values to consider are en_US.UTF-8 or perhaps C.UTF-8.

(I’m not following this closely, IIRC some of the locale data is not available in default installs, or default containers. I’d expect one of the two above (but _not necessarily en_US) to be available. Alternatively, the other locales might be available in packages named something like glibc-langpack*. Random googling finds containers/toolbox#60 and https://fedoraproject.org/wiki/Changes/Glibc_locale_subpackaging .)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay. Installing additional packages isn't a problem. Whatever's needed so the tests run smoothly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If C works fine, it’s not worth the effort/time to change it yet again for theoretical purity.

I vaguely remember Python in particular being not very happy with C + UTF-8, but that’s probably not relevant to us.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, this image is dedicated for skopeo. Anyway, yes I agree, if it's not a problem, no need to fix it. Thanks for your help/insight.


COPY /packages.txt /root/
RUN dnf -y update && \
Expand Down