Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

README: Package 'libbtrfs-dev' doesn't exist on Ubuntu < 18.10 #672

Closed
fhemberger opened this issue Jun 12, 2019 · 4 comments · Fixed by #674
Closed

README: Package 'libbtrfs-dev' doesn't exist on Ubuntu < 18.10 #672

fhemberger opened this issue Jun 12, 2019 · 4 comments · Fixed by #674

Comments

@fhemberger
Copy link
Contributor

I'm building skopeo in a container on Ubuntu 18.04 LTS, the package libbtrfs-dev only exists in versions 10.10 and above.

(Also at least registry to registry copying seems to work fine without it.)

@rhatdan
Copy link
Member

rhatdan commented Jun 12, 2019

Can't you eliminate btrfs from the build?

@fhemberger
Copy link
Contributor Author

fhemberger commented Jun 12, 2019

I just left out installing the dependency and so far, it seems to work fine.
Not sure why you list it as build dependency and in which case it's needed.

@rhatdan
Copy link
Member

rhatdan commented Jun 12, 2019

I think it is needed if you were building with containers/storage == btrfs.

@mtrmac
Copy link
Contributor

mtrmac commented Jun 12, 2019

IIRC the dependency has always been there, it’s just that before 18.10 it was not necessary to install libbtrfs-dev for it (#664). I haven’t looked very hard for other ways to get this working on 18.10, to be fair.

PRs are welcome if there is some other dependency that can be used to pull in the required headers, as long as it works on 18.10 and we can keep the README and Dockerfile.build consistent; it’s been hard enough to keep Dockerfile.build up-to-date when most development of this package is Fedora-based, so keeping a completely separate and likely-to-be-outdated instructions in README for other versions of Ubuntu is not very attractive.

jvanz pushed a commit to jvanz/skopeo that referenced this issue Jun 24, 2019
lsm5 pushed a commit to lsm5/skopeo that referenced this issue Aug 4, 2019
lsm5 pushed a commit to lsm5/skopeo that referenced this issue Aug 10, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants