Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

README: Clarify use of libbtrfs-dev on Ubuntu #674

Merged
merged 1 commit into from
Jun 19, 2019
Merged

README: Clarify use of libbtrfs-dev on Ubuntu #674

merged 1 commit into from
Jun 19, 2019

Conversation

fhemberger
Copy link
Contributor

Fixes #672

@fhemberger
Copy link
Contributor Author

/cc @rhatdan @mtrmac PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR, @fhemberger! The changes LGTM but I'd like to get rid of the additional merge commit. Could you rebase ontop of master to avoid the merge commit in the PR?

@TomSweeneyRedHat
Copy link
Member

Changes LGTM

@fhemberger
Copy link
Contributor Author

@vrothberg Fixed.

@rhatdan
Copy link
Member

rhatdan commented Jun 19, 2019

LGTM.
Merge once tests pass.

@vrothberg vrothberg merged commit ea49bfc into containers:master Jun 19, 2019
@vrothberg
Copy link
Member

Merged, thanks a lot, @fhemberger!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README: Package 'libbtrfs-dev' doesn't exist on Ubuntu < 18.10
4 participants