Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow MS_C2PA_SIGNING OID to pass #314

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Allow MS_C2PA_SIGNING OID to pass #314

merged 2 commits into from
Oct 2, 2023

Conversation

mauricefisher64
Copy link
Collaborator

Changes in this pull request

This PR will allow Microsoft generated C2PA manifests to validate on Verify. Note, this code will soon be replaced when we release Trust list support and its configuration store.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (027c8f9) 78.98% compared to head (f910419) 78.98%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   78.98%   78.98%   -0.01%     
==========================================
  Files          79       79              
  Lines       23349    23350       +1     
==========================================
  Hits        18442    18442              
- Misses       4907     4908       +1     
Files Coverage Δ
sdk/src/cose_validator.rs 67.25% <0.00%> (-0.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauricefisher64 mauricefisher64 merged commit f5492d4 into main Oct 2, 2023
@mauricefisher64 mauricefisher64 deleted the ms_oid branch October 2, 2023 23:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants