Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow MS_C2PA_SIGNING OID to pass #314

Merged
merged 2 commits into from
Oct 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/src/cose_validator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ const SECP384R1_OID: Oid<'static> = oid!(1.3.132 .0 .34);
const PRIME256V1_OID: Oid<'static> = oid!(1.2.840 .10045 .3 .1 .7);

const DOCUMENT_SIGNING_OID: Oid<'static> = oid!(1.3.6 .1 .5 .5 .7 .3 .36);
const MS_C2PA_SIGNING_OID: Oid<'static> = oid!(1.3.6 .1 .4 .1 .311 .76 .59 .1 .9);

/********************** Supported Valiators ***************************************
RS256 RSASSA-PKCS1-v1_5 using SHA-256 - not recommended
Expand Down Expand Up @@ -384,7 +385,8 @@ fn check_cert(
if !(eku.email_protection
|| eku.ocsp_signing
|| eku.time_stamping
|| has_oid(eku, &DOCUMENT_SIGNING_OID))
|| has_oid(eku, &DOCUMENT_SIGNING_OID)
|| has_oid(eku, &MS_C2PA_SIGNING_OID))
{
let log_item = log_item!(
"Cose_Sign1",
Expand Down