Support streaming writes for TIFF #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ff_support * 'main' of https://github.com/contentauth/c2pa-rs: (78 commits) Add Exif Assertion support (#140) (IGNORE) Disregard grep non-zero exit status (#139) Prepare 0.14.0 release (IGNORE) Fix GH Actions logic error that is causing CI failure now (#137) (MINOR) Remove previously embedded manifests for remote manifests (#136) (MINOR) Add support for manifest removal (#123) Prepare 0.13.2 release manifest_data was missing for remote manifests (#135) (IGNORE) Restore cargo-semver-checks step (#129) Prepare 0.13.1 release Add ManifestStore::from_manifest_and_asset_bytes_async (#130) (IGNORE) Disable cargo-semver-checks step (#126) (IGNORE) Enforce semantic versioning requirements during PR validation and publish workflows (#124) Prepare 0.13.0 release Add RemoteManifestUrl Error, returning url (#120) Convert status_log error val to a string so that we can return full errors (#121) Report failures from remote manifest fetch (#116) Fast XMP extraction from PNG (#117) Bump MSRV to 1.59.0 (#118) Make sure there is a single manifest store in the asset (#114) ... # Conflicts: # sdk/src/error.rs # sdk/src/jumbf_io.rs
Clippy fixes
bug fixes
…ff_support # Conflicts: # sdk/Cargo.toml # sdk/src/asset_handlers/mod.rs # sdk/src/asset_handlers/tiff_io.rs # sdk/src/jumbf_io.rs # sdk/src/store.rs
Build fixes
…ff_support # Conflicts: # sdk/Cargo.toml # sdk/src/assertions/data_hash.rs # sdk/src/assertions/thumbnail.rs # sdk/src/assertions/user_cbor.rs # sdk/src/asset_handlers/jpeg_io.rs # sdk/src/ingredient.rs # sdk/src/store.rs # sdk/src/time_stamp.rs
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 79.93% 79.99% +0.05%
==========================================
Files 79 79
Lines 24241 24325 +84
==========================================
+ Hits 19378 19459 +81
- Misses 4863 4866 +3 ☔ View full report in Codecov by Sentry. |
gpeacock
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Thanks for this! It looks fine as it is. Eventually we may want to allow the a file system temp if file_io happens to be available. I'm saying that because eventually we shouldn't need to have the specific file based endpoints here. But I'm not yet sure when that would happen.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Added streaming write support for TIFF based formats
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.