-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update path validator to enforce no beginning or ending of the separator #6233
Conversation
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been For contributor use:
For admin use:
Thank you for your contribution to the Cosmos-SDK! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 🎉
Codecov Report
@@ Coverage Diff @@
## master #6233 +/- ##
==========================================
- Coverage 54.76% 54.75% -0.02%
==========================================
Files 447 447
Lines 26904 26896 -8
==========================================
- Hits 14734 14726 -8
Misses 11126 11126
Partials 1044 1044 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 👍 good catch
… separator (#6233) * update path validator to enforce no beginning or ending of the separator * modify test slightly
Description
Updates path validator to enforce that no path can begin or end with the separator. Previously both were allowed, but I believe this goes against the ICS spec which states:
IMO beginning or ending with the separator is ambiguous to whether the separator is apart of the identifier name (which isn't allowed) or if the second identifier is an empty string (again not allowed). It is also more logical that a separator is always used to separate either two identifiers or an identifier and a constant byte string.
continuation of #6227