[DNM] GoZ Phase 2 Release Branch #6272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @fedekunze wants #6271 (which might need #6206). #6227 and #6233 might be important to add to since making ports/channels with blank id's might cause undefined behavior. I'm not 100% sure however |
|
We are going to talk to @fedekunze to assess the risks here associated with not merging those PRs. It looks like it might or might not be exploitable to halt the GoZ hub. |
* x/ibc: alter id requirements * add regex to validations * comment * update error * test all validators: * fix tests * check for only separators
… separator (#6233) * update path validator to enforce no beginning or ending of the separator * modify test slightly
fedekunze
approved these changes
May 22, 2020
|
@fedekunze thank you for the updates! Tagging commit at head on this branch with |
fedekunze
added a commit
that referenced
this pull request
Jun 10, 2020
fedekunze
added a commit
that referenced
this pull request
Jun 10, 2020
|
Closing this PR as GoZ has ended |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks
ecbb5acb3d42fdd7d4adee37eccd1f1768531440on to thegoz-phase-1tag. If this is the right change set, I will tag the commit at tip of this branch (jack/goz-phase-2) withgoz-phase-2and update the appropriate repos:gaia,relayerandGameOfZones