Add lint check into CI #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegron
reviewed
Jul 23, 2019
| @@ -17,7 +17,8 @@ | |||
| "css": "node ./scripts/css.js", | |||
| "dev": "node ./scripts/dev.server.js", | |||
| "watchTest": "karma start ./config/karma.config.js", | |||
| "lint": "prettier --write src/**/* tests/**/*", | |||
There was a problem hiding this comment.
tu devrais changer le script qui est rouler dans le pre-commit hook aussi plus bas ligne 27
There was a problem hiding this comment.
Oups je l'ai pas vu en effet. C'est updated 👌
mikegron
approved these changes
Jul 23, 2019
L'issue avec ca @mikegron c'est que imaginons User A fais un npm install depuis un linux, ca va le générer en LF. User B fais un npm install depuis un windows, ca va le générer en CRLF, ce qui génère du changement. |
jeremierobert-coveo
approved these changes
Jul 24, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure an opinionated code formatting, running prettier --check on the CI will prevent any commit to get validated by the CI if the code does not respect the prettier configuration.