Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add lint check into CI #11

Merged
merged 3 commits into from
Jul 24, 2019
+14,807 −14,871
Merged

Add lint check into CI #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a55f311
Add lint check into CI
louis-bompart Jul 23, 2019
9864f8c
Update pre-commit script name
louis-bompart Jul 23, 2019
0b19b75
Enforce linting on all files
louis-bompart Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ notifications:
on_success: change
on_failure: always
script:
- npm run lint
- npm run build
- npm run testCoverage
deploy:
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"css": "node ./scripts/css.js",
"dev": "node ./scripts/dev.server.js",
"watchTest": "karma start ./config/karma.config.js",
"lint": "prettier --write src/**/* tests/**/*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu devrais changer le script qui est rouler dans le pre-commit hook aussi plus bas ligne 27

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups je l'ai pas vu en effet. C'est updated 👌

"lint": "prettier --check src/**/* tests/**/*",
"lint-fix": "prettier --write src/**/* tests/**/*",
"clean": "rimraf bin",
"snyk-protect": "snyk protect",
"prepare": "npm run snyk-protect"
Expand Down