Can no longer build for Windows on GitHub Actions due to a deprecation error while building cURL

[phenaproxima]

I tried to rebuild PHP using static-php-cli 2.4.4 in my GitHub Actions workflow, and it didn't work. The doctor command was fine; the source downloads went fine; but the build command fails. Running it with --debug shows me this:

D:\a\cms-launcher\cms-launcher\source\curl\winbuild>nmake /f Makefile.vc WITH_DEVEL=D:\a\cms-launcher\cms-launcher\buildroot WITH_PREFIX=D:\a\cms-launcher\cms-launcher\buildroot mode=static RTLIBCFG=static WITH_SSL=static WITH_NGHTTP2=static WITH_SSH2=static ENABLE_IPV6=yes WITH_ZLIB=static MACHINE=x64 DEBUG=no 

Microsoft (R) Program Maintenance Utility Version 14.42.34436.0
Copyright (C) Microsoft Corporation.  All rights reserved.

Makefile.vc(37) : fatal error U1050: The user must acknowledge the deprecation warning to continue.
Stop.

WARNING:

The winbuild build system is deprecated and will be removed in
September 2025 in favor of the CMake build system.

Please see docs/INSTALL-CMAKE.md : "Migrating from winbuild builds"

To use the winbuild build system you must acknowledge this warning by
setting command line option WINBUILD_ACKNOWLEDGE_DEPRECATED=yes

Here's the full build log: https://github.com/drupal/cms-launcher/actions/runs/13169673265/job/36757562837 (the relevant step is "Build PHP interpreter").

This seems like it might be a quite a bit beyond my pay grade, to be honest. Is there a quick fix here beyond adding the WINBUILD_ACKNOWLEDGE_DEPRECATED flag? I could add that, I'm sure, but actually migrating to cmake is not something I think I'll be able to do.

[crazywhalecc]

Currently Windows lacks a weekly availability check, I will add it in my spare time to ensure that commonly used extensions and dependencies continue to be available.

I will review this change later and evaluate the feasibility of switching to CMake.

[phenaproxima]

This documentation might be helpful: https://github.com/curl/curl/blob/master/docs/INSTALL-CMAKE.md#migrating-from-winbuild-builds

[crazywhalecc]

Changed to cmake for windows build in #600 .

[phenaproxima]

Wow, you're fast! Let me know if I can do anything to help test this.

[crazywhalecc]

I've merged to main branch. GHA test shows it's working, and it would be better if you could test with your specific extension combination locally.

[phenaproxima]

Happy to do it. Will give it a try and report back.

[phenaproxima]

I am delighted to report that it worked just fine: https://github.com/drupal/cms-launcher/actions/runs/13181727850/job/36793955906

[chack1172]

@crazywhalecc the new PHP build is missing SSL support in curl.
@phenaproxima do you also have this issue?

[phenaproxima]

@chack1172 I am not sure :-\ I'm not a Windows user; I'm only building for Windows on GitHub Actions as part of a larger project.